[PATCH] D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass.
Wen-Heng (Jack) Chung via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 14:43:19 PDT 2020
whchung marked 3 inline comments as done.
whchung added inline comments.
================
Comment at: mlir/include/mlir/Conversion/GPUCommon/GPUCommonPass.h:14
+#include <memory>
+#include <string>
+#include <vector>
----------------
rriddle wrote:
> Why are these necessary?
These headers were introduced back in commit c72c6c390710 , but they don't really seem necessary now. I can modify D80142 and remove them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80167/new/
https://reviews.llvm.org/D80167
More information about the llvm-commits
mailing list