[PATCH] D80181: [mlir][spirv] Add remaining cooperative matrix instructions.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVOps.cpp:2738
+  Type type;
+  if (parser.parseColonType(type)) {
+    return failure();
----------------
nit: Drop trivial braces.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVOps.cpp:2746
+
+static void print(spirv::CooperativeMatrixLengthNVOp coopMatrix,
+                  OpAsmPrinter &printer) {
----------------
This looks like it should use the declarative format:

https://mlir.llvm.org/docs/OpDefinitions/#declarative-assembly-format


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVOps.cpp:2756
+static ParseResult parseCooperativeMatrixMulAddNVOp(OpAsmParser &parser,
+                                                    OperationState &state) {
+  SmallVector<OpAsmParser::OperandType, 3> ops;
----------------
Same here and a few others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80181/new/

https://reviews.llvm.org/D80181