[PATCH] D80642: [AIX] Emit AvailableExternally Linkage on AIX

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:442
   case GlobalValue::AvailableExternallyLinkage:
+    if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
+      OutStreamer->emitSymbolAttribute(GVSym, MCSA_Extern);
----------------
DiggerLin wrote:
> I think we look AvailableExternallyLinkage as AvailableExternallyLinkage
> 
> you can change as  
> ```
> case GlobalValue::ExternalLinkage:
> case GlobalValue::AvailableExternallyLinkage:
>     if (MAI->hasDotExternDirective() && GV->isDeclarationForLinker()) {
> }
> ```
> and we do not need code 
> ````
> case GlobalValue::AvailableExternallyLinkage:
>     if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
>    ....
> }
> ````
> here.
sorry it should be "I think we look AvailableExternallyLinkage as ExternalLinkage"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80642/new/

https://reviews.llvm.org/D80642