[PATCH] D80642: [AIX] Emit AvailableExternally Linkage on AIX
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 12:29:44 PDT 2020
DiggerLin added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:442
case GlobalValue::AvailableExternallyLinkage:
+ if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
+ OutStreamer->emitSymbolAttribute(GVSym, MCSA_Extern);
----------------
I think we look AvailableExternallyLinkage as AvailableExternallyLinkage
you can change as
```
case GlobalValue::ExternalLinkage:
case GlobalValue::AvailableExternallyLinkage:
if (MAI->hasDotExternDirective() && GV->isDeclarationForLinker()) {
}
```
and we do not need code
````
case GlobalValue::AvailableExternallyLinkage:
if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
....
}
````
here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80642/new/
https://reviews.llvm.org/D80642
More information about the llvm-commits
mailing list