[PATCH] D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect

Wed May 27 11:56:29 PDT 2020

Hazem added a comment.

In D80594#2057716 <https://reviews.llvm.org/D80594#2057716>, @mravishankar wrote:

> Did a glance through of this. Mostly looks fine to me. Only question is the decorations added here dont seem to be related to the matrix type as such. If so can we split those into two separate CLs. And also I dont see any test for the roundtrip through SPIR-V binary for those decorations....

Makes sense, and just to be sure I understood correctly, I will submit the decorators along with their tests in a separate patch and eliminate them from this matrix type patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80594/new/

https://reviews.llvm.org/D80594