[PATCH] D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect
Mahesh Ravishankar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 10:17:38 PDT 2020
mravishankar requested changes to this revision.
mravishankar added a comment.
Did a glance through of this. Mostly looks fine to me. Only question is the decorations added here dont seem to be related to the matrix type as such. If so can we split those into two separate CLs. And also I dont see any test for the roundtrip through SPIR-V binary for those decorations....
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80594/new/
https://reviews.llvm.org/D80594
More information about the llvm-commits
mailing list