[PATCH] D80570: [LAA] Modify canCheckPtrAtRT to analyze conflicting alias sets only
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 04:17:21 PDT 2020
fhahn added reviewers: anemet, Ayal.
fhahn added a comment.
Thanks for illustrating the issue here. I was a bit surprised this happens, as `canCheckPtrAtRT` already contains code to figure out if runtime checks are needed for a alias set. But it turns out that it sets 'CanDoRT` to false for alias sets with uncomputable bounds, even if no runtime checks are required for the AS.
I've put up D80622 <https://reviews.llvm.org/D80622> with an alternative fix, that slightly extends the existing logic in `canCheckPtrAtRT` to correctly handle this case. I think this has a slight advantage of not having 2 different alias set collections, which potentially could lead to confusion down the road (if the wrong one is used).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80570/new/
https://reviews.llvm.org/D80570
More information about the llvm-commits
mailing list