[PATCH] D77383: [FileCheck] Allow parenthesized expressions
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 03:12:14 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/test/FileCheck/numeric-expression.txt:167
+
+; Numeric expressions using parentheses.
----------------
Nit: too many blank lines
================
Comment at: llvm/test/FileCheck/numeric-expression.txt:179-180
+PAREN-OP-LABEL: PAREN EXPRESSIONS
+PAREN-OP-NEXT: (NUMVAR+2)-1: [[#(NUMVAR+2)-1]]
+PAREN-OP-NEXT: NUMVAR+(2-1): [[#NUMVAR+(2-1)]]
+PAREN-OP-NEXT: NUMVAR+(2-1: [[#NUMVAR+(2-1]]
----------------
Are you able to put these on the same lines as the value themselves, like in the other examples above?
```
PAREN EXPRESSIONS: // PAREN-OP-LABEL: PAREN EXPRESSIONS
11 // PAREN-OP-NEXT: [[#(NUMVAR+2)-1]]
11 // PAREN-OP-NEXT: [[#NUMVAR+(2-1)]]
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77383/new/
https://reviews.llvm.org/D77383
More information about the llvm-commits
mailing list