[PATCH] D77383: [FileCheck] Allow parenthesized expressions
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 27 02:39:56 PDT 2020
arichardson added inline comments.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:755-756
+
+ // Test more closing than opening parentheses. The diagnostic messages are
+ // not ideal, but for now simply check that we reject invalid input.
+ expectDiagnosticError("invalid operand format ')'",
----------------
jhenderson wrote:
> If you plan on improving the situation, perhaps move the second sentence to a TODO comment on the next line.
I don't have any immediate plans since I have lots of other things on my TODO list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77383/new/
https://reviews.llvm.org/D77383
More information about the llvm-commits
mailing list