[PATCH] D80457: AMDGPU/GlobalISel: Fixed handling of non-standard vectors

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 16:55:39 PDT 2020


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:58
+
+  for (unsigned Idx = 1, E = getNumSubRegIndices() - 1; Idx < E; ++Idx) {
+    unsigned Size = getSubRegIdxSize(Idx);
----------------
arsenm wrote:
> Should probably put this into its own function with a FIXME that it should be a table produced by tablegen, also with a call_once?
I am not really sure we initialize TRI exactly once, especially in a JIT, where llvm can be initialized and finalized multiple times.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80457/new/

https://reviews.llvm.org/D80457





More information about the llvm-commits mailing list