[PATCH] D75751: [AArch64][SVE] Implement structured load intrinsics

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 26 09:11:44 PDT 2020


c-rhodes marked 4 inline comments as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1394
+                                               const unsigned Opc,
+                                               unsigned SubRegIdx) {
+  SDLoc dl(N);
----------------
fpetrogalli wrote:
> `SubRegIdx` is always set to `AArch64::zsub0`. Can we remove it from the parameter list of the method and use `AArch64::zsub0` directly inside the function?
Done, you'll have to rebase D77251 once this is merged


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75751/new/

https://reviews.llvm.org/D75751





More information about the llvm-commits mailing list