[PATCH] D80453: [flang] Fixes for problems with declaring procedure entities

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld planned changes to this revision.
PeteSteinfeld marked an inline comment as done.
PeteSteinfeld added a comment.

I plan to change the implementation of `isInterfaceSet()` to `IsInterfaceSet()` and make it be based on the contents of the `ProcInterface`.



================
Comment at: flang/include/flang/Semantics/symbol.h:236
   ProcInterface interface_;
+  bool isInterfaceSet_{false};
   std::optional<const Symbol *> init_;
----------------
tskeith wrote:
> `ProcInterface` already has an "unset" state. When it is default-initialized it has neither a symbol nor type. So `isInterfaceSet` could be determined by checking that rather than maintaining a separate boolean.
Thanks, Tim.  I'll change the implementation of isInterfaceSet().  Since it's no longer an accessor, I'll capitalize it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80453/new/

https://reviews.llvm.org/D80453