[PATCH] D80453: [flang] Fixes for problems with declaring procedure entities

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 25 10:10:27 PDT 2020


tskeith added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:236
   ProcInterface interface_;
+  bool isInterfaceSet_{false};
   std::optional<const Symbol *> init_;
----------------
`ProcInterface` already has an "unset" state. When it is default-initialized it has neither a symbol nor type. So `isInterfaceSet` could be determined by checking that rather than maintaining a separate boolean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80453/new/

https://reviews.llvm.org/D80453





More information about the llvm-commits mailing list