[PATCH] D79066: [Support] Class to facilitate file locking

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In D79066#2050312 <https://reviews.llvm.org/D79066#2050312>, @dblaikie wrote:

> In D79066#2046211 <https://reviews.llvm.org/D79066#2046211>, @labath wrote:
>
> > This looks good to me, modulo a couple of inline comments. But let's give a chance for @dblaikie to look this over too...
>
>
> Yep, looks about right to me. Thanks!
>
> The two changes to Error.h (message/cantFail) look like they're unrelated to this patch & should be removed/not committed?


I think they're needed because this introduces a circular dependency between `raw_ostream` and `Error` classes. Does not seem unreasonable to me, but if we don't want that, then we need to revisit this idea...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79066/new/

https://reviews.llvm.org/D79066