[PATCH] D79066: [Support] Class to facilitate file locking

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 21 17:21:27 PDT 2020


dblaikie added a comment.

In D79066#2046211 <https://reviews.llvm.org/D79066#2046211>, @labath wrote:

> This looks good to me, modulo a couple of inline comments. But let's give a chance for @dblaikie to look this over too...


Yep, looks about right to me. Thanks!

The two changes to Error.h (message/cantFail) look like they're unrelated to this patch & should be removed/not committed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79066/new/

https://reviews.llvm.org/D79066





More information about the llvm-commits mailing list