[PATCH] D60390: FileCheck [10/12]: Add support for signed numeric values
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 21 14:39:09 PDT 2020
thopre added a comment.
In D60390#2048630 <https://reviews.llvm.org/D60390#2048630>, @jhenderson wrote:
> The latest changes are a big improvement on readability, thanks. Did you consider using TEST_P to factor things out further? That way you'd only need to specify the input and expected output values for each test case, with only a single TEST itself.
To make the result more concise that would require sharing fixture and instantiation among TEST_P but I'm not sure how to do it since the values generated in the instantiation are passed to all TEST_P but even operator+ and operator- have different values. If I need separate instantiation per TEST_P then I need separate fixture as well and that becomes more faff that what we have now I feel.
If there's some clever trick please give me some pointers on how to do it as I cannot see it right now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60390/new/
https://reviews.llvm.org/D60390
More information about the llvm-commits
mailing list