[PATCH] D80185: [xray] Add llvm-xray extract support for 32 bit ARM

[Ian Levesque via Phabricator via llvm-commits]

ianlevesque marked an inline comment as done.
ianlevesque added inline comments.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:120
+        if (ObjFile.getBinary()->getArch() == Triple::arm) {
+          if (SupportsRelocation && SupportsRelocation(Reloc.getType())) {
+            Expected<uint64_t> ValueOrErr = Reloc.getSymbol()->getValue();
----------------
MaskRay wrote:
> If we only have `R_ARM_RELATIVE`, you can drop the `if` branch (always false).
It's relocating the xray_fn_idx with absolute relocations still - I think we can just ignore those here but I'd like to do away with them entirely to improve load time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80185/new/

https://reviews.llvm.org/D80185