[PATCH] D80185: [xray] Add llvm-xray extract support for 32 bit ARM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Oh, do we still have R_ARM_ABS32 relocating xray_instr_map? Aren't them all converted to R_ARM_RELATIVE?



================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:120
+        if (ObjFile.getBinary()->getArch() == Triple::arm) {
+          if (SupportsRelocation && SupportsRelocation(Reloc.getType())) {
+            Expected<uint64_t> ValueOrErr = Reloc.getSymbol()->getValue();
----------------
If we only have `R_ARM_RELATIVE`, you can drop the `if` branch (always false).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80185/new/

https://reviews.llvm.org/D80185