[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 20 08:10:52 PDT 2020


wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:321
 
+  bool IncompatAttrs = haveIncompatibleAttrs(*Caller, *Callee);
+
----------------
hoyFB wrote:
> How about moving this into `functionsHaveCompatibleAttributes` in InlineCost.cpp?
That is a good point. I will change it. Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79959/new/

https://reviews.llvm.org/D79959





More information about the llvm-commits mailing list