[PATCH] D79959: [SampleFDO] Add use-sample-profile function attribute

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 22:30:24 PDT 2020


hoyFB added inline comments.


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:321
 
+  bool IncompatAttrs = haveIncompatibleAttrs(*Caller, *Callee);
+
----------------
How about moving this into `functionsHaveCompatibleAttributes` in InlineCost.cpp?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79959/new/

https://reviews.llvm.org/D79959





More information about the llvm-commits mailing list