[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> Add an lld option(--cache-ir-symtab) to enable this behavior (default off). In the long run, I think it is beneficial to turn it on by default.

I tested this patch internally. There is some minor performance loss turning on --cache-ir-symtab. That may be because we don't have mismatching versions of bitcode files.
I guess many users do the same (same version of bitcode files), so I am unsure this should be on by default.



================
Comment at: lld/ELF/Driver.cpp:506
 
+  if (config->cacheIRSymTabAheadOfTime)
+    irSymTabCache = new lto::IRSymtabFileCache();
----------------
Drop `AheadOfTime`. It is not part of the option name.

If this is an LTO specific option, `--lto-*` may be more suitable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261