[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 2 inline comments as done.
ychen added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:510
+    driver->addFile(path->first, /*withLOption=*/path->second);
   else
     error(toString(f) +
----------------
MaskRay wrote:
> Why is the change?
To factor out the common code `getPath` to be used later.


================
Comment at: lld/ELF/InputFiles.cpp:1527
 
+  if (config->dependentLibraries && irSymTabCache) {
+    std::vector<std::string> filesToUpgrade;
----------------
MaskRay wrote:
> This logic requires a test.
I added a test case to the deplib test file. It should cover this if statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261