[PATCH] D80177: [lld-macho] Set __PAGEZERO size to 4GB

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Symbols.h:110
+    return d->isec->getFileOffset() + d->value;
+  return 0;
+}
----------------
smeenai wrote:
> This is *definitely* follow-up territory, but we should figure out if it ever makes sense for `getFileOffset` to be called on a non-defined symbol, and if not, just fail loudly in that case instead of silently returning 0.
oh good point. I doubt it would ever be valid; I can just insert a `fatal` here. Does it really need to be in a follow-up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80177/new/

https://reviews.llvm.org/D80177