[PATCH] D80177: [lld-macho] Set __PAGEZERO size to 4GB

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 19 16:00:16 PDT 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Looks great, thanks!



================
Comment at: lld/MachO/Symbols.h:110
+    return d->isec->getFileOffset() + d->value;
+  return 0;
+}
----------------
This is *definitely* follow-up territory, but we should figure out if it ever makes sense for `getFileOffset` to be called on a non-defined symbol, and if not, just fail loudly in that case instead of silently returning 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80177/new/

https://reviews.llvm.org/D80177





More information about the llvm-commits mailing list