[PATCH] D79508: [mlir][gpu] Refactor functions for workgroup and private buffer attributions.

Tue May 19 09:49:09 PDT 2020

whchung added a comment.

In D79508#2044267 <https://reviews.llvm.org/D79508#2044267>, @herhut wrote:

> In D79508#2044128 <https://reviews.llvm.org/D79508#2044128>, @whchung wrote:
>
> > In D79508#2043577 <https://reviews.llvm.org/D79508#2043577>, @herhut wrote:
> >
> > > @whchung Are you still interested in moving this forward?
> >
> >
> > @herhut I just revised the patch to address your review comments. Getting rid of the counter for private allocations is less than ideal in my applications but I've found ways to get around them. Could you give this patch another look? Thanks.
>
>
> I think you misunderstood my comment. I liked having the getters and interface for private attributions. My point was that you do not need to store a count as an attribute for the private attributions but instead could always compute the number of private attributes via `getNumOperands() - getType().getNumInputs() - getNumWorkgroupAttributions()`. Sorry for not being clear.
>
> Using that approach should also cover your use cases?

@herhut Yes, that's exactly how I compute the number of private attributes right now in my application.

BTW it seems nowadays pre-merge checks would always fail on Windows due to logic in SPIR-V dialect.

  [2020-05-19T14:57:38.942Z] tools\mlir\include\mlir/Dialect/SPIRV/SPIRVSerialization.inc(4334): fatal error C1061: compiler limit: blocks nested too deeply

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79508/new/

https://reviews.llvm.org/D79508