[PATCH] D79508: [mlir][gpu] Refactor functions for workgroup and private buffer attributions.
Stephan Herhut via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 19 08:41:37 PDT 2020
herhut added a comment.
In D79508#2044128 <https://reviews.llvm.org/D79508#2044128>, @whchung wrote:
> In D79508#2043577 <https://reviews.llvm.org/D79508#2043577>, @herhut wrote:
>
> > @whchung Are you still interested in moving this forward?
>
>
> @herhut I just revised the patch to address your review comments. Getting rid of the counter for private allocations is less than ideal in my applications but I've found ways to get around them. Could you give this patch another look? Thanks.
I think you misunderstood my comment. I liked having the getters and interface for private attributions. My point was that you do not need to store a count as an attribute for the private attributions but instead could always compute the number of private attributes via `getNumOperands() - getType().getNumInputs() - getNumWorkgroupAttributions()`. Sorry for not being clear.
Using that approach should also cover your use cases?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79508/new/
https://reviews.llvm.org/D79508
More information about the llvm-commits
mailing list