[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 16:19:47 PDT 2020


ychen marked 2 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/lib/Object/IRSymtab.cpp:312
   Hdr.Version = storage::Header::kCurrentVersion;
-  setStr(Hdr.Producer, kExpectedProducerName);
+  if (getenv("LLVM_REEVAL_IR_SYMTAB_PRODUCER"))
+    setStr(Hdr.Producer, getExpectedProducerName());
----------------
MaskRay wrote:
> Do we have a better testing this other than using an environment variable?
Not that I'm aware of. @tejohnson any suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261





More information about the llvm-commits mailing list