[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 15 16:19:44 PDT 2020


ychen added a comment.

In D71261#2038881 <https://reviews.llvm.org/D71261#2038881>, @tejohnson wrote:

> @MaskRay and @ruiu are the best reviewers for the LLD changes.
>
> One high level question and one request:
>
> Does this affect the laziness of Lazy object/archive files? It looked to me as if those perhaps were going to be upgraded non-lazily after this change.


Yes, it indeed pre-upgrades the IR symbol table of Lazy object/archive files. It is a little bit wasteful potentially. Good thing is that parallelization makes the cost trivial.

> It would be good to add equivalent support to gold-plugin.cpp as well so that those remain in sync on functionality.

Understood. I will look into that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261





More information about the llvm-commits mailing list