[PATCH] D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description

[Digger via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:27
+  // address.
+  EXPECT_LT(SIT1, SIT2);
+
----------------
jhenderson wrote:
> If EXPECT_GT doesn't work, perhaps you could test something like `EXPECT_FALSE(SIT2 < SIT1);` etc? Probably also `EXPECT_FALSE(SIT1 < SIT1)`?
> 
> I think it's important to demonstrate both the true cases, like you have done, and the false cases. If you don't then your less than operator function could be the below to make all the unit tests pass:
> 
> ```
> bool operator< (auto LHS, auto RHS) {
>   return true;
> }
> ```
I do not think we need to test EXPECT_FALSE(SIT1 < SIT1) , if there are two symbol is the same, we do not care which symbol is display.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78387/new/

https://reviews.llvm.org/D78387