[PATCH] D78387: [AIX][XCOFF] add symbol priority for the llvm-objdump -D -symbol-description

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/unittests/MC/MCDisassemblerTest.cpp:27
+  // address.
+  EXPECT_LT(SIT1, SIT2);
+
----------------
If EXPECT_GT doesn't work, perhaps you could test something like `EXPECT_FALSE(SIT2 < SIT1);` etc? Probably also `EXPECT_FALSE(SIT1 < SIT1)`?

I think it's important to demonstrate both the true cases, like you have done, and the false cases. If you don't then your less than operator function could be the below to make all the unit tests pass:

```
bool operator< (auto LHS, auto RHS) {
  return true;
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78387/new/

https://reviews.llvm.org/D78387