[PATCH] D77808: [SCCP] Use conditional info with AND/OR branch conditions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 264199.
fhahn added a comment.

In D77808#1984593 <https://reviews.llvm.org/D77808#1984593>, @fhahn wrote:

> In D77808#1981709 <https://reviews.llvm.org/D77808#1981709>, @efriedma wrote:
>
> > Much cleaner now.
> >
> > In terms of merging information, hmm, that's a downside.  No good ideas off the top of my head; I mean, you could store a vector of constant ranges instead of just one, but that gets complicated fast.
>
>
> yes, I am not sure if we really want to go there. I'll try and see if there are any reasonable alternatives


I've updated the patch to not use the information from chained predicates, if the original info is != constant. That gets rid of the regressions and keeps things simple.  What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77808/new/

https://reviews.llvm.org/D77808

Files:
  llvm/lib/Transforms/Scalar/SCCP.cpp
  llvm/test/Transforms/SCCP/conditions-ranges.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77808.264199.patch
Type: text/x-patch
Size: 5819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200515/adae7049/attachment.bin>