[PATCH] D79736: [PowerPC][NFC] Cleanup load/store spilling code

Kamau Bridgeman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 12:31:10 PDT 2020


kamaub accepted this revision as: kamaub.
kamaub marked an inline comment as done.
kamaub added a comment.
This revision is now accepted and ready to land.

LGTM, one pre-commit nit with the indentation.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:177
   const PPCRegisterInfo RI;
+  const unsigned StoreSpillOpcodesArray[2][SOK_LastOpcodeSpill] =
+      StoreOpcodesForSpill;
----------------
kamaub wrote:
> enums start at `0` so i think this should be `SOK_LastOpcodeSpill +1` right?
I realise now that this is on purpose as the `#define` opcodes only have 15 entries, my apologies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79736/new/

https://reviews.llvm.org/D79736





More information about the llvm-commits mailing list