[PATCH] D79618: [llvm-dwarfdump] Make commandline arguments consistent.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 263909.
Higuoxing added a comment.

Address comments.

- Add double-dashes to the rest of test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79618/new/

https://reviews.llvm.org/D79618

Files:
  llvm/test/tools/llvm-dwarfdump/cmdline.test
  llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp


Index: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
===================================================================
--- llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -72,10 +72,7 @@
     return ValueOptional;
   }
 
-  void printOptionInfo(const Option &O, size_t GlobalWidth) const {
-    outs() << "  -" << O.ArgStr;
-    Option::printHelpStr(O.HelpStr, GlobalWidth, getOptionWidth(O));
-  }
+  StringRef getValueName() const override { return StringRef(); }
 
   void printOptionDiff(const Option &O, OffsetOption V, OptVal Default,
                        size_t GlobalWidth) const {
Index: llvm/test/tools/llvm-dwarfdump/cmdline.test
===================================================================
--- llvm/test/tools/llvm-dwarfdump/cmdline.test
+++ llvm/test/tools/llvm-dwarfdump/cmdline.test
@@ -2,29 +2,29 @@
 RUN: llvm-dwarfdump --help 2>&1 | FileCheck --check-prefix=HELP %s --implicit-check-not=out-file
 HELP: USAGE: llvm-dwarfdump{{[^ ]*}} [options] <input object files or .dSYM bundles>
 HELP: Color Options
-HELP: -color
+HELP: --color
 HELP: Generic Options
-HELP: -help
-HELP: -help-list
-HELP: -version
+HELP: --help
+HELP: --help-list
+HELP: --version
 HELP: Section-specific Dump Options
-HELP: -debug-info            - Dump the .debug_info section
-HELP: -eh-frame
+HELP: --debug-info            - Dump the .debug_info section
+HELP: --eh-frame
 HELP: Specific Options
-HELP: -diff
-HELP: -find
-HELP: -ignore-case
-HELP: -lookup
-HELP: -name
+HELP: --diff
+HELP: --find
+HELP: --ignore-case
+HELP: --lookup
+HELP: --name
 HELP: -o=<filename>
-HELP: -parent-recurse-depth=<N>
-HELP: -recurse-depth=<N>
-HELP: -regex
-HELP: -show-children
-HELP: -show-form
-HELP: -show-parents
-HELP: -statistics
-HELP: -summarize-types
+HELP: --parent-recurse-depth=<N>
+HELP: --recurse-depth=<N>
+HELP: --regex
+HELP: --show-children
+HELP: --show-form
+HELP: --show-parents
+HELP: --statistics
+HELP: --summarize-types
 HELP: @FILE
 
 RUN: llvm-dwarfdump --version 2>&1 | FileCheck --check-prefix=VERSION %s


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79618.263909.patch
Type: text/x-patch
Size: 2074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200514/58d5d1aa/attachment.bin>