[PATCH] D79618: [llvm-dwarfdump] Make commandline arguments consistent.

Wed May 13 01:03:10 PDT 2020

jhenderson added a comment.

If you are planning on using the description as your commit message, please rephrase the second point "some section dumping options have inconsistent indentation". Also change the first one saying "debug" options to "section dumping options", as the phrasing you use suggests to me that they are for debugging the tool, rather than provide useful output!

If you could fix that, and also add the double-dashes to the rest of the test, I think that would be sufficient for this.

================
Comment at: llvm/test/tools/llvm-dwarfdump/cmdline.test:11
 HELP: Section-specific Dump Options
-HELP: -debug-info            - Dump the .debug_info section
+HELP: --debug-info            - Dump the .debug_info section
 HELP: -eh-frame
----------------
Higuoxing wrote:
> jhenderson wrote:
> > Why have you singled out the -debug-info option for this extra testing? What about the other options?
> Because there's only one test case for `--debug-*` options. Should I add more tests for this?
I was thinking more why do `-color`/`-help` etc not use double dashes.

I'm not sure that we need extra testing beyond that point, as I don't think it will provide much use.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79618/new/

https://reviews.llvm.org/D79618