[PATCH] D79328: lld: Let find_package(LLD) work
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 15:51:31 PDT 2020
arsenm added a comment.
In D79328#2035234 <https://reviews.llvm.org/D79328#2035234>, @smeenai wrote:
> LGTM, given it's basically just matching what clang already does.
>
> > I'm slightly confused since it looks like the build is manually
> > generating a very similar *Targets.cmake to what gets auto-generated
> > by export(). After generating the build, I see:
> >
> > build/tools/lld/cmake/modules/CMakeFiles/Export/lib/cmake/lld/LLDTargets.cmake
> > build/lib/cmake/lld/LLDTargets.cmake
> > build/tools/clang/cmake/modules/CMakeFiles/Export/lib/cmake/clang/ClangTargets.cmake
> > build/lib/cmake/clang/ClangTargets.cmake
> >
> > The cmake generated one "wins" and is what I see in the installed
> > tree. I'm guessing this is somehow for the benefit of old versions
> > of cmake?
>
> I believe both the CMakeFiles version and the lib version are generated by CMake. The first one should just be an internal CMake file.
Any comment on "lld" vs "LLD"? Should the project() name be capitalized?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79328/new/
https://reviews.llvm.org/D79328
More information about the llvm-commits
mailing list