[PATCH] D79328: lld: Let find_package(LLD) work

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a reviewer: phosek.
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM, given it's basically just matching what clang already does.

> I'm slightly confused since it looks like the build is manually
>  generating a very similar *Targets.cmake to what gets auto-generated
>  by export(). After generating the build, I see:
> 
>   build/tools/lld/cmake/modules/CMakeFiles/Export/lib/cmake/lld/LLDTargets.cmake
>   build/lib/cmake/lld/LLDTargets.cmake
>   build/tools/clang/cmake/modules/CMakeFiles/Export/lib/cmake/clang/ClangTargets.cmake
>   build/lib/cmake/clang/ClangTargets.cmake
> 
> The cmake generated one "wins" and is what I see in the installed
>  tree. I'm guessing this is somehow for the benefit of old versions
>  of cmake?

I believe both the CMakeFiles version and the lib version are generated by CMake. The first one should just be an internal CMake file.



================
Comment at: lld/CMakeLists.txt:224
+add_subdirectory(cmake/modules)
\ No newline at end of file

----------------
Looks like you got rid of the EOF newline


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79328/new/

https://reviews.llvm.org/D79328