[PATCH] D79837: [cmake] Update creation of object library dependencies for LINK_LIBS PUBLIC

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer updated this revision to Diff 263610.
stephenneuendorffer marked an inline comment as done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79837/new/

https://reviews.llvm.org/D79837

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -483,7 +483,8 @@
         "PUBLIC;PRIVATE"
         ${ARG_LINK_LIBS})
       foreach(link_lib ${LINK_LIBS_ARG_PUBLIC})
-        if(TARGET ${link_lib})
+        # Can't specify a dependence on -lpthread
+        if(NOT ${link_lib} MATCHES "-.*")
           add_dependencies(${obj_name} ${link_lib})
         endif()
       endforeach()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79837.263610.patch
Type: text/x-patch
Size: 520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200513/cb768e61/attachment.bin>