[PATCH] D79837: [cmake] Update creation of object library dependencies for LINK_LIBS PUBLIC

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 22:05:13 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:487
+        # Can't specify a dependence on -lpthread
+        if(NOT ${link_lib} MATCHES "-l.*")
           add_dependencies(${obj_name} ${link_lib})
----------------
Probably anything that starts with `-` isn't intended to be a dependency...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79837/new/

https://reviews.llvm.org/D79837





More information about the llvm-commits mailing list