[PATCH] D79793: Simplify MachineVerifier's block-successor verification.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 11:49:35 PDT 2020
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nits
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:691
+ // analyzeBranch.
+ if (TBB && !MBB->isSuccessor(TBB))
+ report("MBB exits via jump or conditional branch, but its target isn't a "
----------------
Braces
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:695
+ MBB);
+ if (FBB && !MBB->isSuccessor(FBB))
+ report("MBB exits via conditional branch, but its target isn't a CFG "
----------------
Braces
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:723
+ continue;
+ // if we might have a fallthrough, and the successor is the fallthrough
+ // block, that's also ok.
----------------
Capitalize
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79793/new/
https://reviews.llvm.org/D79793
More information about the llvm-commits
mailing list