[PATCH] D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835)

dmajor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 09:39:25 PDT 2020


dmajor accepted this revision.
dmajor added a comment.
This revision is now accepted and ready to land.

Thanks a lot for taking this over! Looks good from my side but you may wish to wait for a more expert review.

I also confirmed that this still fixes our issue on the 10.0 branch. I had to remove `-scev-cheap-expansion-budget=1` since that didn't exist in 10, but fortunately it's not needed there. Since it wasn't a clean merge, I put the diff in P8220 <https://reviews.llvm.org/P8220> if it makes your/Tom's life easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79787/new/

https://reviews.llvm.org/D79787





More information about the llvm-commits mailing list