[PATCH] D79787: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 08:34:52 PDT 2020


lebedev.ri updated this revision to Diff 263443.
lebedev.ri added a comment.

In D79787#2031598 <https://reviews.llvm.org/D79787#2031598>, @dmajor wrote:

> Is it a problem that the test case doesn't fail on trunk before the patch, since `SCEVMinMaxExpr` is no longer automatically high cost? I noted this in D79720 <https://reviews.llvm.org/D79720> but wasn't sure how to nudge the code around it.


Oh right, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79787/new/

https://reviews.llvm.org/D79787

Files:
  llvm/lib/Transforms/Utils/LoopUtils.cpp
  llvm/test/Transforms/IndVarSimplify/pr45835.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79787.263443.patch
Type: text/x-patch
Size: 6535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200512/a9e65afe/attachment-0001.bin>


More information about the llvm-commits mailing list