[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 09:07:11 PDT 2020
foad added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/MsgPackDocument.h:370-371
+ Merger = [](DocNode *DestNode, DocNode SrcNode, DocNode MapKey) {
+ return (DestNode->isMap() && SrcNode.isMap()) ||
+ (DestNode->isArray() && SrcNode.isArray());
+ });
----------------
Can't the body of this default merger be just `llvm_unreachable();`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79671/new/
https://reviews.llvm.org/D79671
More information about the llvm-commits
mailing list