[PATCH] D79671: [MsgPack] MsgPackDocument::readFromBlob now merges
Scott Linder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 19:59:41 PDT 2020
scott.linder added a reviewer: dineshkb-amd.
scott.linder added a comment.
Dinesh is working on merging metadata in ROCm CompilerSupport using MsgPackDocument, and it fell out that merging YAML metadata was also handled transparently. What is the advantage to doing this via a function pointer passed to `readFromBlob`? It doesn't seem to save any copies as you still need to be able to compare the nodes; is it just a matter of readability? Would it be reasonable to also add a callback for `fromYAML`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79671/new/
https://reviews.llvm.org/D79671
More information about the llvm-commits
mailing list