[PATCH] D49132: Fix gcov profiling on big-endian machines
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 01:02:35 PDT 2020
uweigand added a comment.
Hmm, I still think the read/write_64bit_value change is correct, GCC does read/write 64-bit counter values as lo/hi pairs even on big-endian systems.
However, it does appear that you're right about the read_le_32bit_value change; I've added this for the tags checks, but this looks wrong. GCC does read/write those in native endian byte order. I guess this part of the change should be reverted, and instead the code that writes tags should be changed to use write_32bit_value instead of write_bytes.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49132/new/
https://reviews.llvm.org/D49132
More information about the llvm-commits
mailing list