[PATCH] D49132: Fix gcov profiling on big-endian machines

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 19:27:44 PDT 2020


MaskRay added a comment.

This change is wrong. I can understand the intention: llvm-cov does not process big-endian .gcno/.gcda correctly.
gcov reads/writes integral values in the executable's endianness. On a big-endian machine, the values are stored in big-endian. This change is not going to work with gcov shipped by GCC.

I am fixing some gcov problems. We should just `UNSUPPORTED: host-byteorder-big-endian` until llvm-cov and compiler-rt/lib/profile are actually fixed for big endian.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49132/new/

https://reviews.llvm.org/D49132





More information about the llvm-commits mailing list