[PATCH] D79697: [lld-macho] Re-add dylink-lazy test

[Eric Christopher via llvm-commits]

Except, of course, now you're testing the assembler and other tools in an
attempt to just test some linking :)

That said, I'm ok either way - but this seems like a deviation from normal
without a compelling argument other than the "why have yaml2obj at all?" :)

-eric

On Mon, May 11, 2020 at 5:18 PM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added a subscriber: echristo.
> MaskRay added a comment.
>
> > @echristo on llvm-commits: Would this be better off as a yaml2obj file
> as input? It would remove the assembler checks and even the dyld checks.
>
> In lld/ELF, I find that yaml2obj tests tend to be overly complex. They are
> occasionally used to synthesize invalid input which can't be generated by
> an assembler (llvm-mc).
> Other than that, they tend to be quite cumbersome. For an example, to
> represent a jump target which can be relocated, a YAML file needs several
> lines to represent the text section,
> followed by some raw bytes (like using `.inst` directives in assembly),
> then another relocation section with a relocation record. These add up to
> tens of lines.
>
> On the contrary, in assembly, one can achieve that with just one line.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79697/new/
>
> https://reviews.llvm.org/D79697
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200511/4d13c50a/attachment.html>