[PATCH] D79697: [lld-macho] Re-add dylink-lazy test
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 17:18:44 PDT 2020
MaskRay added a subscriber: echristo.
MaskRay added a comment.
> @echristo on llvm-commits: Would this be better off as a yaml2obj file as input? It would remove the assembler checks and even the dyld checks.
In lld/ELF, I find that yaml2obj tests tend to be overly complex. They are occasionally used to synthesize invalid input which can't be generated by an assembler (llvm-mc).
Other than that, they tend to be quite cumbersome. For an example, to represent a jump target which can be relocated, a YAML file needs several lines to represent the text section,
followed by some raw bytes (like using `.inst` directives in assembly), then another relocation section with a relocation record. These add up to tens of lines.
On the contrary, in assembly, one can achieve that with just one line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79697/new/
https://reviews.llvm.org/D79697
More information about the llvm-commits
mailing list