[PATCH] D79570: [MC] Fix PR45805: infinite recursion in assembler

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmLayout.h:36
+  /// Set of fragments currently being laid out.
+  mutable SmallPtrSet<MCFragment *, 4> LayingOutFragmentsSet;
+
----------------
I feel uneasy that we are adding another mutable member. Can mutable be avoided?


================
Comment at: llvm/test/MC/AsmParser/layout-interdependency.s:6
+
+# CHECK: layout-interdependency.s:7:7: error: expected assembly-time absolute expression
+.fill (data_start - fct_end), 1, 42
----------------
Change the line number to `[[#@LINE+1]]`


================
Comment at: llvm/test/MC/AsmParser/layout-interdependency.s:8
+.fill (data_start - fct_end), 1, 42
+.fill (fct_end - data_start), 1, 42
+
----------------
Doesn't the second line have an error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79570/new/

https://reviews.llvm.org/D79570