[PATCH] D79570: [MC] Fix PR45805: infinite recursion in assembler

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 11:50:43 PDT 2020


thopre added inline comments.


================
Comment at: llvm/include/llvm/MC/MCAsmLayout.h:57
+  bool isFragmentValidating(const MCFragment *F) const {
+    return LayingOutFragmentsSet.find(F) != LayingOutFragmentsSet.end();
+  }
----------------
MaskRay wrote:
> count
> 
> Why is called Validating instead of layouting?
To echo the isFragmentValid but yeah isFragmentLayouting is clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79570/new/

https://reviews.llvm.org/D79570





More information about the llvm-commits mailing list