[PATCH] D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow)

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 11:18:03 PDT 2020


mehdi_amini added a comment.

In D79578#2029762 <https://reviews.llvm.org/D79578#2029762>, @ftynse wrote:

> I don't know who are the members of the flang team (is there a list?) and would feel concerned if we need to block any changes to MLIR APIs for review by people other than regular MLIR reviewers.


I don't think this is the request. The request is just "don't break the build". 
The pre-merge testing will test flang as well, but you would have had to rebase the patch after you landed the dependent ones first so that the pre-merge testing could work (I think marking the dependencies in Phabricator would have worked also).

In general trying to get the pre-merge testing green before pushing changes is safer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79578/new/

https://reviews.llvm.org/D79578





More information about the llvm-commits mailing list